MediaWiki talk:Gadget-SetTestWikiPreference.js

Search

@Krinkle: So, regarding your edit to this gadget a few weeks ago: My unfortunate typo in the variable reference (search was supposed to be searched on line 50), while potentially causing a line of unnecessary jQuery to run in unusual circumstances, did not actually break the script, due to the whole "IDs as globals" mess that all browsers seem to ship these days. (Obviously, this still wasn't ideal.) In any case, could you please revert and fix the typo? I no longer have editing access since interface-admin rights were split from admin rights.

(Unfortunately, the feature will still be broken for users of non-legacy Vector, due to the unfortunate new behaviour of overwriting the search box on focus, but that's something I'll have to fix sometime later.)

Thanks for all the maintenance edits, by the way. --Yair rand (talk) 03:23, 15 September 2021 (UTC)

@Yair rand Hi, I'd be happy to try to repair it. I'll need to know a little bit about how to test it though. I didn't think about "IDs as globals", that's interesting. Note though that the search variable, error was real and found while using Legacy Vector. I don't remember how I encountered it, but looking in the HTML source of this talk page, I do not see an element with the ID of "search", and evaluating search from the Firefox devtools console, I get Uncaught ReferenceError: search is not defined which suggests it's not dynamically created in some other way either. --Krinkle (talk) 17:14, 15 September 2021 (UTC)